[avenger] ## Update wasm golden file for pi engine changes - #47255
Conversation
Regenerate pi.golden to match pi_engine.go updates (PI_OFFLINE env var, removed api.pi.ai domain) that were merged from main. Co-Authored-By: Claude <noreply@anthropic.com>
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅ |
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. No ADR enforcement needed: PR does not have the 'implementation' label and has ≤100 new lines of code in business logic directories (only 2 additions detected). |
|
✅ PR Code Quality Reviewer completed the code quality review. |
There was a problem hiding this comment.
Pull request overview
Regenerates the Pi engine WASM golden fixture to match current compiler output.
Changes:
- Adds
PI_OFFLINE: 1. - Removes
api.pi.aifrom firewall domains.
Show a summary per file
| File | Description |
|---|---|
pkg/workflow/testdata/TestWasmGolden_AllEngines/pi.golden |
Updates expected Pi workflow output. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Medium
|
✅ Test Quality Sentinel completed test quality analysis. No test files were added or modified in this PR. Test Quality Sentinel skipped. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Skills-Based Review
Applied /diagnosing-bugs — no issues found; approving.
This is a mechanical golden file regeneration. The two changes are internally consistent:
- api.pi.ai correctly removed from allowDomains (engine no longer needs external access)
- PI_OFFLINE: 1 env var correctly added to match the merged pi_engine.go behaviour
- PR description documents verification steps (make fmt, make lint, make test-unit all pass)
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 17.7 AIC · ⌖ 7.29 AIC · ⊞ 6.7K
Comment /matt to run again
There was a problem hiding this comment.
Golden file update looks correct. The removal of api.pi.ai from allowDomains is consistent with the addition of PI_OFFLINE: 1, and both changes align with the merged pi_engine.go updates. No issues found.
🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 16.1 AIC · ⌖ 5.09 AIC · ⊞ 5K
There was a problem hiding this comment.
✅ LGTM — mechanical golden update
The two changes are consistent and correct:
PI_OFFLINE: 1env var added to disable live PI calls during test execution.api.pi.airemoved from the firewall allowlist, which is the expected paired change when the engine goes offline.
No logic errors, edge cases, or security concerns in the diff.
🔎 Code quality review by PR Code Quality Reviewer · sonnet46 14.9 AIC · ⌖ 4.48 AIC · ⊞ 5.6K
Comment /review to run again
|
🎉 This pull request is included in a new release. Release: |
Summary
Updates the wasm golden file for the pi engine to reflect two related behavioral changes: the pi engine now runs in offline mode, and the firewall allowlist no longer includes
api.pi.ai.Changes
pkg/workflow/testdata/TestWasmGolden_AllEngines/pi.goldenDetails
Golden file diff summary
api.pi.aifromnetwork.allowDomainsin the embeddedawf-config.jsonpayload.PI_OFFLINE: 1to the job step environment block.These two changes are consistent: setting
PI_OFFLINE: 1signals the pi engine to operate without making outbound calls toapi.pi.ai, so the domain no longer needs to be in the firewall allowlist.Type